GSOC Debugger by kr-2003 · Pull Request #2 · kr-2003/xeus-cpp

kr-2003 · 2025-05-17T08:54:09Z

No description provided.

kr-2003 · 2025-05-17T08:56:00Z

kr-2003 · 2025-05-17T13:19:41Z

kr-2003 · 2025-05-19T13:05:29Z

The connection to lldb-dap now persists. As you can see we can get ACK(response of first msg) and then response of init_request.

kr-2003 · 2025-05-19T15:47:59Z

Can't recieve multiple responses from lldb-dap.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 98. Check the log or trigger a new build to see more.

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+        // Register request handlers
+        register_request_handler(
+            "inspectVariables",
+            std::bind(&debugger::inspect_variables_request, this, _1),


warning: no header providing "std::placeholders::_1" is directly included [misc-include-cleaner]

std::bind(&debugger::inspect_variables_request, this, _1), ^

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+        // Register request handlers
+        register_request_handler(
+            "inspectVariables",
+            std::bind(&debugger::inspect_variables_request, this, _1),


warning: prefer a lambda to std::bind [modernize-avoid-bind]

Suggested change

std::bind(&debugger::inspect_variables_request, this, _1),

[this](auto && PH1) { return inspect_variables_request(std::forward<decltype(PH1)>(PH1)); },

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+            std::bind(&debugger::inspect_variables_request, this, _1),
+            false
+        );
+        register_request_handler("stackTrace", std::bind(&debugger::stack_trace_request, this, _1), false);


warning: prefer a lambda to std::bind [modernize-avoid-bind]

Suggested change

register_request_handler("stackTrace", std::bind(&debugger::stack_trace_request, this, _1), false);

register_request_handler("stackTrace", [this](auto && PH1) { return stack_trace_request(std::forward<decltype(PH1)>(PH1)); }, false);

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+            false
+        );
+        register_request_handler("stackTrace", std::bind(&debugger::stack_trace_request, this, _1), false);
+        register_request_handler("attach", std::bind(&debugger::attach_request, this, _1), true);


warning: prefer a lambda to std::bind [modernize-avoid-bind]

Suggested change

register_request_handler("attach", std::bind(&debugger::attach_request, this, _1), true);

register_request_handler("attach", [this](auto && PH1) { return attach_request(std::forward<decltype(PH1)>(PH1)); }, true);

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+        register_request_handler("attach", std::bind(&debugger::attach_request, this, _1), true);
+        register_request_handler(
+            "configurationDone",
+            std::bind(&debugger::configuration_done_request, this, _1),


warning: prefer a lambda to std::bind [modernize-avoid-bind]

Suggested change

std::bind(&debugger::configuration_done_request, this, _1),

[this](auto && PH1) { return configuration_done_request(std::forward<decltype(PH1)>(PH1)); },

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+            true
+        );
+
+        std::cout << "Debugger initialized with config: " << m_debugger_config.dump() << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << "Debugger initialized with config: " << m_debugger_config.dump() << std::endl;

std::cout << "Debugger initialized with config: " << m_debugger_config.dump() << '\n';

github-actions · 2025-05-20T07:10:08Z

src/xdebugger.cpp

+
+    debugger::~debugger()
+    {
+        std::cout << "Stopping debugger..........." << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << "Stopping debugger..........." << std::endl;

std::cout << "Stopping debugger..........." << '\n';

github-actions · 2025-05-20T07:10:09Z

src/xdebugger.cpp

+        m_lldb_port = xeus::find_free_port(100, 9999, 10099);
+        if (m_lldb_port.empty())
+        {
+            std::cout << "Failed to find a free port for LLDB-DAP" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << "Failed to find a free port for LLDB-DAP" << std::endl;

std::cout << "Failed to find a free port for LLDB-DAP" << '\n';

github-actions · 2025-05-20T07:10:09Z

src/xdebugger.cpp

+        if (std::getenv("XEUS_LOG") != nullptr)
+        {
+            std::ofstream out("xeus.log", std::ios_base::app);
+            out << "===== DEBUGGER CONFIG =====" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

out << "===== DEBUGGER CONFIG =====" << std::endl;

out << "===== DEBUGGER CONFIG =====" << '\n';

github-actions · 2025-05-20T07:10:09Z

src/xdebugger.cpp

+        {
+            std::ofstream out("xeus.log", std::ios_base::app);
+            out << "===== DEBUGGER CONFIG =====" << std::endl;
+            out << m_debugger_config.dump() << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

out << m_debugger_config.dump() << std::endl;

out << m_debugger_config.dump() << '\n';

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 96. Check the log or trigger a new build to see more.

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+#include "xeus-cpp/xdebugger.hpp"
+
+#include <arpa/inet.h>  // For inet_pton(), htons()
+#include <chrono>       // For std::chrono (used in sleep_for)


warning: included header inet.h is not used directly [misc-include-cleaner]

Suggested change

#include <chrono> // For std::chrono (used in sleep_for)

#include <chrono> // For std::chrono (used in sleep_for)

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+
+#include <arpa/inet.h>  // For inet_pton(), htons()
+#include <chrono>       // For std::chrono (used in sleep_for)
+#include <cstdlib>


warning: included header chrono is not used directly [misc-include-cleaner]

Suggested change

#include <cstdlib>

#include <cstdlib>

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+#include <chrono>       // For std::chrono (used in sleep_for)
+#include <cstdlib>
+#include <fcntl.h>
+#include <fstream>


warning: included header fcntl.h is not used directly [misc-include-cleaner]

Suggested change

#include <fstream>

#include <fstream>

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+#include <fstream>
+#include <iostream>
+#include <netinet/in.h>  // For sockaddr_in, AF_INET
+#include <sys/socket.h>  // For socket(), connect(), send(), recv()


warning: included header in.h is not used directly [misc-include-cleaner]

Suggested change

#include <sys/socket.h> // For socket(), connect(), send(), recv()

#include <sys/socket.h> // For socket(), connect(), send(), recv()

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+#include <iostream>
+#include <netinet/in.h>  // For sockaddr_in, AF_INET
+#include <sys/socket.h>  // For socket(), connect(), send(), recv()
+#include <sys/types.h>


warning: included header socket.h is not used directly [misc-include-cleaner]

Suggested change

#include <sys/types.h>

#include <sys/types.h>

github-actions · 2025-06-05T17:35:29Z

src/xdebugger.cpp

+#include <sys/socket.h>  // For socket(), connect(), send(), recv()
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <thread>


warning: included header wait.h is not used directly [misc-include-cleaner]

Suggested change

#include <thread>

#include <thread>

github-actions · 2025-06-05T17:35:30Z

src/xdebugger.cpp

+#include <sys/wait.h>
+#include <thread>
+#include <unistd.h>
+


warning: included header unistd.h is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2025-06-05T17:35:30Z

src/xdebugger.cpp

+
+namespace xcpp
+{
+    debugger::debugger(


warning: constructor does not initialize these fields: m_tcp_socket, m_tcp_connected [cppcoreguidelines-pro-type-member-init]

include/xeus-cpp/xdebugger.hpp:69:

- int m_tcp_socket; - bool m_tcp_connected; + int m_tcp_socket{}; + bool m_tcp_connected{};

github-actions · 2025-06-05T17:35:30Z

src/xdebugger.cpp

+namespace xcpp
+{
+    debugger::debugger(
+        xeus::xcontext& context,


warning: no header providing "xeus::xcontext" is directly included [misc-include-cleaner]

src/xdebugger.cpp:14:

+ #include <xeus/xeus_context.hpp>

github-actions · 2025-06-05T17:35:30Z

src/xdebugger.cpp

+{
+    debugger::debugger(
+        xeus::xcontext& context,
+        const xeus::xconfiguration& config,


warning: no header providing "xeus::xconfiguration" is directly included [misc-include-cleaner]

src/xdebugger.cpp:14:

+ #include <xeus/xkernel_configuration.hpp>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 85. Check the log or trigger a new build to see more.

github-actions · 2025-06-09T11:18:04Z

src/xdebugger.cpp

+    debugger::debugger(
+        xeus::xcontext& context,
+        const xeus::xconfiguration& config,
+        const std::string& user_name,


warning: no header providing "std::string" is directly included [misc-include-cleaner]

src/xdebugger.cpp:9:

- #include <sys/socket.h> // For socket(), connect(), send(), recv() + #include <string> + #include <sys/socket.h> // For socket(), connect(), send(), recv()

github-actions · 2025-06-09T11:18:04Z

src/xdebugger.cpp

+        const xeus::xconfiguration& config,
+        const std::string& user_name,
+        const std::string& session_id,
+        const nl::json& debugger_config


warning: no header providing "nlohmann::json" is directly included [misc-include-cleaner]

src/xdebugger.cpp:9:

- #include <sys/socket.h> // For socket(), connect(), send(), recv() + #include <nlohmann/json_fwd.hpp> + #include <sys/socket.h> // For socket(), connect(), send(), recv()

github-actions · 2025-06-09T11:18:04Z

src/xdebugger.cpp

+        const xeus::xconfiguration& config,
+        const std::string& user_name,
+        const std::string& session_id,
+        const nl::json& debugger_config


warning: pass by value and use std::move [modernize-pass-by-value]

src/xdebugger.cpp:13:

- #include <unistd.h> + #include <utility> + #include <unistd.h>

Suggested change

const nl::json& debugger_config

nl::json debugger_config

src/xdebugger.cpp:42:

- , m_debugger_config(debugger_config) + , m_debugger_config(std::move(debugger_config))

include/xeus-cpp/xdebugger.hpp:40:

- const nl::json& debugger_config); + nl::json debugger_config);

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+        const std::string& session_id,
+        const nl::json& debugger_config
+    )
+        : xdebugger_base(context)


warning: no header providing "xeus::xdebugger_base" is directly included [misc-include-cleaner]

src/xdebugger.cpp:14:

+ #include <xeus-zmq/xdebugger_base.hpp>

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+              context,
+              config,
+              xeus::get_socket_linger(),
+              xdap_tcp_configuration(xeus::dap_tcp_type::client, xeus::dap_init_type::parallel, user_name, session_id),


warning: no header providing "xeus::dap_tcp_type" is directly included [misc-include-cleaner]

src/xdebugger.cpp:14:

+ #include <xeus-zmq/xdap_tcp_client.hpp>

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+        // Register request handlers
+        register_request_handler(
+            "inspectVariables",
+            std::bind(&debugger::inspect_variables_request, this, _1),


warning: no header providing "std::bind" is directly included [misc-include-cleaner]

src/xdebugger.cpp:7:

- #include <iostream> + #include <functional> + #include <iostream>

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+
+    bool debugger::start_lldb()
+    {
+        std::cout << "debugger::start_lldb" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << "debugger::start_lldb" << std::endl;

std::cout << "debugger::start_lldb" << '\n';

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+        code += "int main() {\n";
+
+        // Construct LLDB-DAP command arguments
+        code += "    vector<string> lldb_args = {\"lldb-dap\", \"--port\", \"" + m_lldb_port + "\"};\n";


warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]

Suggested change

code += " vector<string> lldb_args = {\"lldb-dap\", \"--port\", \"" + m_lldb_port + "\"};\n";

code += R"( vector<string> lldb_args = {"lldb-dap", "--port", ")" + m_lldb_port + "\"};\n";

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+        {
+            if (it->contains("initCommands"))
+            {
+                std::cout << "Adding init commands to lldb-dap command" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << "Adding init commands to lldb-dap command" << std::endl;

std::cout << "Adding init commands to lldb-dap command" << '\n';

github-actions · 2025-06-09T11:18:05Z

src/xdebugger.cpp

+            if (it->contains("initCommands"))
+            {
+                std::cout << "Adding init commands to lldb-dap command" << std::endl;
+                for (const auto& cmd : it->at("initCommands").get<std::vector<std::string>>())


warning: no header providing "std::vector" is directly included [misc-include-cleaner]

src/xdebugger.cpp:14:

+ #include <vector>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 227. Check the log or trigger a new build to see more.

github-actions · 2025-06-12T08:24:44Z